fix: reverting changes from W-21239801, @W-21055675@#1394
Open
jfeingold35 wants to merge 2 commits intomainfrom
Open
fix: reverting changes from W-21239801, @W-21055675@#1394jfeingold35 wants to merge 2 commits intomainfrom
jfeingold35 wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The solution for W-21239801 (merged as PR #1384) was misguided, and needs to be reverted. This PR is me doing that. To do that, I deleted the
.sfdevrc.jsonfile, and copy-pasted thepackage.jsonandyarn.lockfiles from the repo immediately before I merged #1384 over their current counterparts.This will have the following impacts:
@oclif/coreand@salesforce/coreexternal nuts will start failing (or will fail with a different reason if they were already failing). This is frustrating, but ultimately necessary, and we'll figure out the proper resolution for these failures in the fullness of time.What issues does this PR fix or reference?
It's related to @W-21055675@, but only insofar as
plugin-datahas acted as a blocker for PRs on other repos.