fix: updating mocha dependency @W-21055675@#1393
Closed
jfeingold35 wants to merge 1 commit intomainfrom
Closed
Conversation
Contributor
Author
|
Never mind, this isn't doing anything. I've misunderstood something important, and I'm trying to find out what. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bumps the mocha dependency from 10.x to 11.x.
What issues does this PR fix or reference?
@W-21055675@. The XNut tests for sfdx-core are currently failing, and I believe this is because the mocha dependencies are out of sync. I am not 100% positive that this is the case, however there is no possible harm in bumping the mocha dependency even if it's not the ultimate cause of my problems, so I'm doing it on principle.