Skip to content

Add aria-label to router-link for accessibility#554

Open
VividLemon wants to merge 1 commit intosalesforce:masterfrom
VividLemon:patch-1
Open

Add aria-label to router-link for accessibility#554
VividLemon wants to merge 1 commit intosalesforce:masterfrom
VividLemon:patch-1

Conversation

@VividLemon
Copy link

There's also an accessibility issue on the span, that only visually impaired people may not be capable of utilizing this element without a mouse with the "mouseenter" "mouseleave"

But :to=deepLink is a syntax error, so this component may not be used... I didn't think it would build properly if it were used

What does this PR do?

What gif best describes this PR or how it makes you feel?

Completion checklist

  • Additions and changes have unit tests
  • pre-commit hooks and tests are passing
  • The pull request has been appropriately labeled using the provided PR labels
  • If the UI contents or JavaScript files have been modified, generate a new example report:
# Generate the updated Javascript bundle
just build-js

# Generate the example report
just generate-report

There's also an accessibility issue on the span, that only visually impaired people may not be capable of utilizing this element without a mouse with the "mouseenter" "mouseleave"

But `:to=deepLink` is a syntax error, so this component may not be used... I didn't think it would build properly if it were used
@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @VividLemon to sign the Salesforce Inc. Contributor License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant