Selective GNOME 42 conversion with automatic redundancy cleanup#63
Open
raul-lezameta wants to merge 1 commit intosaint-13:mainfrom
Open
Selective GNOME 42 conversion with automatic redundancy cleanup#63raul-lezameta wants to merge 1 commit intosaint-13:mainfrom
raul-lezameta wants to merge 1 commit intosaint-13:mainfrom
Conversation
- Only converts wallpapers with exactly 2 images to GNOME 42 syntax - Prevents duplicate wallpaper entries by deleting old XML files - Adds early exit if no eligible wallpapers are found - Improves user experience by avoiding conversion conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements a paired conversion and cleanup strategy for GNOME 42 wallpaper support: wallpapers with exactly 2 images are converted to GNOME 42 syntax AND their old XML files are deleted to eliminate redundancy.
Problem Solved
Previously, updating wallpapers to GNOME 42 syntax created duplicates - the old XML file remained alongside the new one. This PR eliminates that by deleting the old files for converted wallpapers while preserving multi-image wallpapers in their original format.
What This Feature Does
Benefits
✅ Eliminates Redundancy: Old XML files deleted when converted to new syntax
✅ No Duplicates: Each wallpaper exists in only one format in the system
✅ Clarity: Simple light/dark variants distinct from truly dynamic multi-step wallpapers
✅ Preservation: Complex multi-image wallpapers retain full time-step functionality
✅ Cleaner System: Removes obsolete files, reducing clutter and confusion
✅ User Experience: Only the preferred GNOME 42 format available for 2-image wallpapers
Technical Details
filter_wallpapers(): Selects only wallpapers with exactly 2 imagesdelete_old_xml_files(): Removes old XML entries for converted wallpapersTesting Performed
✅ Confirmed conversion of 2-image wallpapers to GNOME 42 syntax
✅ Verified old XML files are deleted for converted wallpapers
✅ Confirmed multi-image wallpapers remain untouched
✅ Tested no duplicates remain in system
✅ Validated proper file cleanup and naming conventions