[codex] include recording security counts in truth query#67
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fab78f8f92
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| attention_counts:.source_summary.attention_state_counts, | ||
| security:{ | ||
| scanned:([.projects[] | select(.security.alerts_available == true)] | length), | ||
| with_open_high_critical:([.projects[] | select(((.security.dependabot_critical // 0) + (.security.dependabot_high // 0) + (.security.code_scanning_critical // 0) + (.security.code_scanning_high // 0) + (.security.secret_scanning_open // 0)) > 0)] | length), |
There was a problem hiding this comment.
When a current snapshot contains a repo that has only code-scanning/secret-scanning counts, this jq reports it in with_open_high_critical, but the generated portfolio and weekly security summaries count only scanned repos whose Dependabot high+critical total is nonzero (src/portfolio_truth_types.py:181-183, src/weekly_command_center.py:421-430). That makes the checklist produce a different number than the Risk + Security/Weekly Digest surfaces it is meant to script, so live recordings can overstate the “repos with open high/critical Dependabot alerts” claim.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
Fixes discussion: #66 (comment)