Skip to content

Conversation

@conradludgate
Copy link
Contributor

fixes #201

Screenshot 2026-01-03 at 15 57 09

The Debug impl is still incorrect, but this is an improvement nonetheless.

@conradludgate conradludgate force-pushed the fix-extra-roots-target-docs branch from 88e7e54 to 3431c5c Compare January 3, 2026 21:55
Copy link
Collaborator

@complexspaces complexspaces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a much better spot to me even if all the cross-platform weirdness isn't gone yet.

IIUC this PR correctly, we are now overriding rustdoc's automatic availability generation and replacing it with manual declarations that new and impl ServerCertVerifier are available everywhere and that new_with_extra_roots is available everywhere but Android all without caring about the underlying OS the docs are built on.

@djc djc merged commit 345c4ad into rustls:main Jan 3, 2026
20 checks passed
@djc
Copy link
Member

djc commented Jan 3, 2026

Thanks!

@ofek
Copy link

ofek commented Jan 4, 2026

Thanks! Out of curiosity, what is the long-term fix/standard practice for such situations? I assume it's somehow about moving to a single interface with methods that are implemented by calling internal functions that are conditional at build time but I'm not certain.

@Ralith
Copy link
Collaborator

Ralith commented Jan 4, 2026

Static indirection through a facade seems like the way to go, yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect documentation for Verifier

5 participants