Conversation
|
Thanks!
I'm supportive but defer to @ctz for the final decision since I'm a biased Nix-enjoyer-slash-sicko. I think if he's onboard we should add some CI integration to try and keep away the bitrot. |
|
Yes I don't object to this living here; though I don't use Nix myself so something to defend it in CI is extremely desirable. |
|
Running the test on GitHub Actions is a little over 3 minutes: https://github.com/stephank/rustls-openssl-compat/actions/runs/12256865517/job/34193063214 I think I'll run this work by NixOS itself first. There's a decent chance they'll land it any way, and NixOS CI has hot caches for this stuff, unlike GitHub. NixOS/nixpkgs#363932 3 minutes isn't that bad, but it's also fetching a whole bunch from So I guess the remaining point of this PR is: do we want broader distribution testing in this repo? :) |
That doesn't seem unreasonable to me.
Cool 👍
Over in rustls-platform-verifier where I landed a bit of Nix we're using
My feeling is that if we're going to keep some .nix in this repo it should be tested in CI. If the NixOS PR lands and you think it's better tested in that repo then I'd vote we remove the .nix here vs keeping both in sync with only the external repo getting test coverage. |
I'm not sure if this is useful to land here / something we'd want to maintain here, but I thought I'd open a draft PR to al least share the idea.
This adds a
dist/package.nixcontaining a Nix package definition. We can't just swap out libssl on NixOS, so this recreates a typical install, reusing the OpenSSL libcrypto and headers via symlinks.The
flake.nixis optional convenience for consuming the git repo as a dependency.I derived an automated integration test with Nginx from an existing NixOS test. With Nix installed, you can run this with
nix-build tests/nixos.nix.Turns out HTTP/3 doesn't yet work, though. 🤷