Skip to content

rdrand: allow(unused_unsafe) when calling __cpuid #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
newpavlov merged 2 commits into from
Dec 27, 2025
Merged

rdrand: allow(unused_unsafe) when calling __cpuid #770

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2ea45f
rdrand: `allow(unused_unsafe)` when calling `__cpuid`
tarcieri Dec 27, 2025
558282a
Add TODO for MSRV 1.94
tarcieri Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/backends/rdrand.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,14 @@ fn is_rdrand_good() -> bool {
{
// SAFETY: All Rust x86 targets are new enough to have CPUID, and we
// check that leaf 1 is supported before using it.
//
// TODO(MSRV 1.94): remove allow(unused_unsafe) and the unsafe blocks for `__cpuid`.
#[allow(unused_unsafe)]
let cpuid0 = unsafe { arch::__cpuid(0) };
if cpuid0.eax < 1 {
return false;
}
#[allow(unused_unsafe)]
let cpuid1 = unsafe { arch::__cpuid(1) };

let vendor_id = [
Expand Down