Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the "non-negative" statement needs to be added to the
Integertrait itself. If all implementations do not need to return a non-negative value, then the "non-negative" statement should be removed fromnum_integer::gcd.I imagine "non-negative" invariant may be important for
num_rational::Ratio<T>to work properly. If we do not add the statement to theIntegertrait itself, then a statement may be needed in thenum-rationalcrate.Tangent:
lcminclude the same statement? As far as I can tell,lcmis implemented to return only non-negative numbers for primitive integers andBigInt.num-bigintcrate has the outdated "positive" wording instead of "non-negative". Should I update that too?