Simplifications for slicing-related types#940
Merged
bluss merged 4 commits intorust-ndarray:masterfrom Mar 15, 2021
Merged
Conversation
jturner314
force-pushed
the
make-sliceinfo-sized
branch
from
e7dc93d to
0ec7c59
Compare
This allows the `s![]` macro to return an owned type, without requiring an explicit `&` when calling slicing methods.
The original reason for `SliceInfo` being `?Sized` and these conversions was to work around the limitations of the slicing methods taking a type involving `Dimension::SliceArg`. Now that the slicing methods take `I: SliceArg<D>` as the parameter type, these conversions are no longer necessary, and `SliceInfo` doesn't need to be `?Sized`.
jturner314
force-pushed
the
make-sliceinfo-sized
branch
from
0ec7c59 to
fb7e94d
Compare
Member
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that now that we no longer have a slicing API based on the
Dimension::SliceArgassociated type, thes![]macro can return an owned type, the tricky conversions involving pointer casts no longer need to exist, andSliceInfono longer needs to be?Sized.This PR does the following:
SliceArg<D> for &T.Irather than&I.s![]macro return an ownedSliceInforather than a reference.SliceInfoinvolving tricky pointer casts with similar conversions not involving pointer casts.SliceInfobeSizedand remove the#[repr(transparent)]attribute. These changes aren't necessary, but seem like a nice simplification.