Add missing safety checks to From<&[[A; N]]> for ArrayView and From<&mut [[A; N]]> for ArrayViewMut#1131
Merged
bluss merged 2 commits intorust-ndarray:masterfrom Mar 10, 2024
Conversation
jturner314
force-pushed
the
fix-convert-to-view-check
branch
from
1fb2f42 to
bbeed89
Compare
bluss
approved these changes
Dec 7, 2021
bluss
force-pushed
the
fix-convert-to-view-check
branch
from
bbeed89 to
a68435d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing #1130, I noticed these missing checks introduced in #980. In the first commit, the new
deny_slice_with_too_many_rows_to_arrayview*2tests fail in release mode. The second commit fixes the code so that the tests pass.