Skip to content

Conversation

@akern40
Copy link

@akern40 akern40 commented Dec 24, 2025

This is a large PR that repeatedly does a simple process: find locations of &ArrayBase and replace it with &ArrayRef, then remove any unused generics. The only change that isn't in this theme is for EigGeneralized, for which we need a new trait to provide a tuple-friendly implementation (see #412 for more details).

Closes #412

@akern40 akern40 requested a review from Dirreke December 24, 2025 18:18
@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

❌ Patch coverage is 72.15190% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.35%. Comparing base (edff246) to head (729edc0).
⚠️ Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
ndarray-linalg/src/tridiagonal.rs 14.28% 18 Missing ⚠️
ndarray-linalg/src/krylov/householder.rs 66.66% 3 Missing ⚠️
ndarray-linalg/src/solveh.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
- Coverage   87.65%   87.35%   -0.31%     
==========================================
  Files          65       65              
  Lines        3895     3937      +42     
==========================================
+ Hits         3414     3439      +25     
- Misses        481      498      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move to ArrayRef instead of ArrayBase

1 participant