Add support for InputEvent::TextAction events #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes IME actions via an InputEvent::TextAction event so that it's possible to recognise when text entry via an input method is finished. This adds an `TextInputAction` enum to represent the action key on a soft keyboard, such as "Done". For example, this makes it possible to emit Ime::Commit events in Winit.
Member
Author
|
cc: @jb55 @nicoburns it could be good if you're able to take a look at this regarding IME enabling for Android I've tested this with winit 0.30 + egui in combination with #214 and #215 |
Member
Author
|
If anyone wants to smoke test this then you can try running the agdk-egui example in this rust-android-example branch: https://github.com/rust-mobile/rust-android-examples/tree/rib/wip/ime-test That example will fetch my draft changes for winit from https://github.com/rib/winit/tree/rib/pr/android-ime-0.30 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes IME actions via an
InputEvent::TextActionevent so that it's possible to recognise when text entry via an input method is finished.This adds an
TextInputActionenum to represent the action key on a soft keyboard, such as "Done".For example, this makes it possible to emit
Ime::Commitevents in Winit.Note: this is based on #214 which needs to land before this