feat: implement ruleset bypass actor #2199
Conversation
Dry-run check results |
amustaque97
force-pushed
the
feat/2192-implement-ruleset-bypass-actors
branch
from
aa4aaa5 to
29a954f
Compare
amustaque97
force-pushed
the
feat/2192-implement-ruleset-bypass-actors
branch
from
29a954f to
023b6b5
Compare
| source_type: RulesetSourceType::Repository, | ||
| enforcement: RulesetEnforcement::Active, | ||
| bypass_actors: None, | ||
| bypass_actors: None, // Will be populated when applying the diff |
There was a problem hiding this comment.
We can discuss if this needs to be changed. I can think of making ID resolution methods available on the read client.
I'm okay with this comment because the current implementation is read-only
| } | ||
|
|
||
| /// Custom deserializer for actor_id that distinguishes between null and missing | ||
| fn deserialize_actor_id<'de, D>(deserializer: D) -> Result<Option<ActorId>, D::Error> |
There was a problem hiding this comment.
I'm not sure if this can be written better. I would love to learn. This is generated code but it works. Here is the video reference.
https://github.com/user-attachments/assets/e5ee56f5-4d83-4312-8cb5-a42c42fd82d4
https://github.com/user-attachments/assets/b16f1d52-746b-4afa-9217-7b2a49720f90
There was a problem hiding this comment.
Maybe we can simplify things by only implementing what we need.
For example, we only need to allow github apps and github teams for now I think.
For the crates-io repo we only need github apps for sure.
We don't use deploy keys anywhere if I remember correctly. So we don't need to implement them.
I think we should have a pragmatic approach where we implement stuff only when we find we use it in some repos 👍
Maybe I should have catch this earlier so that you saved time implementing this. If that's the case, sorry! D:
amustaque97
requested review from
Mark-Simulacrum,
jdno,
marcoieni and
pietroalbini
as code owners
2 participants
Closes: #2192