Mention struct-like variants in enums2 hint instead of anonymous structs#2353
Open
orzechow wants to merge 1 commit intorust-lang:mainfrom
Open
Mention struct-like variants in enums2 hint instead of anonymous structs#2353orzechow wants to merge 1 commit intorust-lang:mainfrom
orzechow wants to merge 1 commit intorust-lang:mainfrom
Conversation
Author
|
See also my PR to improve the Rust docs on that matter: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current hint of the enums2 exercise uses an outdated term for struct-like enum variants, which is confusing to Rust newbies:
The term
anonymous structseems outdated. It's neither mentioned in the Rust book on structs or enums, nor the references on structs or enums.A web search rather points to a Rust Forum thread hinting
The only place I found this term, is in the Rust docs on enums, but not in the docs on structs.
It seems like Rust used this term once, but not anymore. See also #1204 and the 2018 edition Rust book on enums.
Instead the book on enums now calls it
named fields, like a struct.The reference on enums uses the term
struct-like enum variant.Therefore, I'd suggest updating this hint to
struct-like enum variants.