toolchain: avoid broad substring replacement in get_toolchain_binary#1637
Open
AayushMainali-Github wants to merge 1 commit intorust-lang:mainfrom
Open
toolchain: avoid broad substring replacement in get_toolchain_binary#1637AayushMainali-Github wants to merge 1 commit intorust-lang:mainfrom
AayushMainali-Github wants to merge 1 commit intorust-lang:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1636
Summary
Make
get_toolchain_binary()only rewrite recognized linker suffixes instead of doing broad substring replacement on the whole linker filename.Details
The old code chained
.replace("ld", ...),.replace("gcc", ...),.replace("clang", ...), and.replace("cc", ...), which could rewrite unrelated parts of the linker name.This changes the logic to only handle known endings:
gccclangccldThe existing
ld.lldspecial case is kept.