Skip to content

[beta] Revert "Build shared LLVM lib for windows-gnullvm"#155285

Open
jieyouxu wants to merge 1 commit intorust-lang:betafrom
jieyouxu:revert-gnullvm-link-shared-beta
Open

[beta] Revert "Build shared LLVM lib for windows-gnullvm"#155285
jieyouxu wants to merge 1 commit intorust-lang:betafrom
jieyouxu:revert-gnullvm-link-shared-beta

Conversation

@jieyouxu
Copy link
Copy Markdown
Member

@jieyouxu jieyouxu commented Apr 14, 2026 •
edited
Loading

This reverts commit 1d1280a.

Looks like this causes problems (#155268) with certain LLVM bin tools not finding libLLVM on *-windows-gnullvm. This PR is a minimal revert to return us to known state to alleviate time pressure to investigate.

r? @mati865

@jieyouxu
Revert "Build shared LLVM lib for windows-gnullvm"
847a841 
This reverts commit 1d1280a.

Looks like this causes problems with certain LLVM bin tools not finding
`libLLVM` on `*-windows-gnullvm`. This commit is a _minimal_ revert to
return us to known state to alleviate time pressure to investigate.
@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 14, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 14, 2026

⚠️ Warning ⚠️

  • Pull requests are usually filed against the main branch for this repo, but this one is against beta. Please double check that you specified the right target!

@jieyouxu jieyouxu changed the title [BETA] Revert "Build shared LLVM lib for windows-gnullvm" [beta] Revert "Build shared LLVM lib for windows-gnullvm" Apr 14, 2026
@jieyouxu jieyouxu mentioned this pull request Apr 14, 2026
Open
mati865
mati865 approved these changes Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mati865 mati865 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me whenever you think this is ready

View changes since this review

@jieyouxu
Copy link
Copy Markdown
Member Author

jieyouxu commented Apr 14, 2026

Unilaterally calling this beta-accepted since this is an obvious revert-to-baseline for *-windows-gnullvm (Tier 2) and target maintainer is the reviewer so
@rustbot label +beta-accepted

@bors r+ rollup=never (beta revert)

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 14, 2026

📌 Commit 847a841 has been approved by jieyouxu

It is now in the queue for this repository.

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 14, 2026
@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2026
@JonathanBrouwer
Copy link
Copy Markdown
Contributor

JonathanBrouwer commented Apr 14, 2026 •
edited
Loading

@bors p=6
Scheduling this before the rollup, since amount of rollupable PRs is small

@jieyouxu jieyouxu added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 14, 2026
@jieyouxu
Copy link
Copy Markdown
Member Author

jieyouxu commented Apr 14, 2026

(Pls ignore the label fiddling, I'm trying to trigger a beta backport thread)

@jieyouxu jieyouxu added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. labels Apr 14, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 14, 2026 •
edited
Loading

⌛ Testing commit 847a841 with merge 74ab15c...

Workflow: https://github.com/rust-lang/rust/actions/runs/24398950192

rust-bors bot pushed a commit that referenced this pull request Apr 14, 2026
@bors
Auto merge of #155285 - jieyouxu:revert-gnullvm-link-shared-beta, r=j…
74ab15c 
…ieyouxu

[beta] Revert "Build shared LLVM lib for windows-gnullvm"

This reverts commit 1d1280a.

Looks like this causes problems (#155268) with certain LLVM bin tools not finding `libLLVM` on `*-windows-gnullvm`. This PR is a _minimal_ revert to return us to known state to alleviate time pressure to investigate.

r? @mati865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mati865 mati865 mati865 approved these changes

Assignees

@mati865 mati865

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jieyouxu @rustbot @JonathanBrouwer @mati865