Skip to content

Conversation

@ranger-ross
Copy link
Member

@ranger-ross ranger-ross commented Dec 12, 2025

Backporting bug fix rust-lang/cargo#16385 for issue reported in rust-lang/cargo#16384

Also see Cargo backport PR rust-lang/cargo#16386

r? @weihanglo


2 commits in 2c283a9a5c5968eeb9a8f12313f04feb1ff8dfac..083ac5135f967fd9dc906ab057a2315861c7a80d
2025-12-04 16:47:28 +0000 to 2025-12-11 23:19:46 -0500

@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 12, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2025

⚠️ Warning ⚠️

Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weihanglo weihanglo changed the title [beta] Backport Cargo bug fix for 1.93 [beta-1.93] Backport Cargo bug fix for 1.93 Dec 12, 2025
@ranger-ross
Copy link
Member Author

Sure, if you decide to backport that, lmk and I'll bump the submodule to that commit :)

@weihanglo
Copy link
Member

rust-lang/cargo#16399 is merged. @ranger-ross could you help update and I'll r+ it? Thanks!

@ranger-ross
Copy link
Member Author

Updated! Please double check as my submodule-fu is not the strongest.

Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks a lot!

View changes since this review

@weihanglo
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Dec 16, 2025

📌 Commit 2a8e61f has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2025
@bors
Copy link
Collaborator

bors commented Dec 16, 2025

⌛ Testing commit 2a8e61f with merge 6dfb801...

@bors
Copy link
Collaborator

bors commented Dec 16, 2025

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 6dfb801 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 16, 2025
@bors bors merged commit 6dfb801 into rust-lang:beta Dec 16, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Dec 16, 2025
@ranger-ross ranger-ross deleted the backport-cargofix branch December 16, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants