Open
Conversation
I've added a `ParseCallbacks` method called `field_name` which is given the same `FieldInfo` struct that `field_visibility` takes. I wasn't entirely sure where to change field names, I ended up doing it in what was `deanonymize_fields` which has been renamed to `assign_field_names` as suggested by [this comment](rust-lang#1058 (comment)) Related to rust-lang#1097 and rust-lang#1098
wolfd
added a commit
to AutoPallet/orbbec-sdk-rs
that referenced
this pull request
Apr 3, 2026
This is a pretty big (breaking!) change. - Update OrbbecSDK submodule, vendor in crate - Rework binding generation to change how properties work. - Add macros for common patterns of calling orbbec sdk functions. I've also collapsed the other PRs on this repo into this one, with separate commits for each. The first commit updates the OrbbecSDK submodule, and changes the build process to vendor the contents of the OrbbecSDK folder into the crate. Caveat: OrbbecSDK writes out a couple files to its source directory, so we need to copy the whole source directory to OUT_DIR before building. The next commit reworks the binding generation to use Rust-y enums instead of raw integers. In many cases, we're now using the rust enums directly in the public API. This isn't complete, since I would like to rename struct members too (see rust-lang/rust-bindgen#3358). The third commit adds macros for common patterns of calling the C SDK functions, and rewrites all of the current calls to the C SDK to use them. I think my vision is to further reduce the sys/ layer so that src/ does most of the work. The rest of the commits are adding various features to the public API. Topic: vendor-submodule
Author
|
r? @emilio |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a
ParseCallbacksmethod calledfield_namewhich is given the sameFieldInfostruct thatfield_visibilitytakes.I wasn't entirely sure where to change field names, I ended up doing it in what was
deanonymize_fieldswhich has been renamed toassign_field_namesas suggested by this comment.Related to #1097 and #1098