make matching brace work when cursor not at bracket#21792
Merged
ChayimFriedman2 merged 2 commits intorust-lang:masterfrom Apr 5, 2026
Merged
make matching brace work when cursor not at bracket#21792ChayimFriedman2 merged 2 commits intorust-lang:masterfrom
ChayimFriedman2 merged 2 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
requested changes
Mar 22, 2026
| Some(matching_node.text_range().start()) | ||
| } else { | ||
| // when the offset is not at a brace | ||
| let thingy = file.syntax().token_at_offset(offset).last()?; |
Contributor
There was a problem hiding this comment.
We already have file.syntax().token_at_offset(offset). There is a potential for code reuse here.
Contributor
There was a problem hiding this comment.
Also thingy is not exactly a descriptive name.
bend-n
force-pushed
the
make-matching-brace-almost-always-proc
branch
from
89cb5dd to
53ceaf7
Compare
ChayimFriedman2
requested changes
Mar 30, 2026
| let parent = brace_token.parent()?; | ||
| if brace_token.kind() == T![|] && !ast::ParamList::can_cast(parent.kind()) { | ||
| cov_mark::hit!(pipes_not_braces); | ||
| return None; |
Contributor
There was a problem hiding this comment.
Why is that? I see no reason to exclude pipes.
ChayimFriedman2
approved these changes
Apr 5, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by jumping to the parents enclosing bracket.
see #t-compiler/rust-analyzer > experimental/matching braces when not on a brace @ 💬
this would make the behavior match vscodes go to bracket command.
behavior pictured:
2026-03-10.17-53-48.mp4