Skip to content

fix: Fix not complete .not in condition#21526

Merged
ChayimFriedman2 merged 1 commit intorust-lang:masterfrom
A4-Tacks:comp-not-in-cond
Feb 4, 2026
Merged

fix: Fix not complete .not in condition#21526
ChayimFriedman2 merged 1 commit intorust-lang:masterfrom
A4-Tacks:comp-not-in-cond

Conversation

@A4-Tacks
Copy link
Copy Markdown
Member

Example

fn foo(cond: bool) {
    if cond.$0
}

Before this PR

...
sn deref         *expr
sn ref           &expr
...

After this PR

...
sn deref         *expr
sn not           !expr
sn ref           &expr
...

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 26, 2026
@ChayimFriedman2 ChayimFriedman2 added this pull request to the merge queue Feb 3, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 3, 2026
Example
---
```rust
fn foo(cond: bool) {
    if cond.$0
}
```

**Before this PR**

```text
...
sn deref         *expr
sn ref           &expr
...
```

**After this PR**

```text
...
sn deref         *expr
sn not           !expr
sn ref           &expr
...
```
@A4-Tacks
Copy link
Copy Markdown
Member Author

A4-Tacks commented Feb 4, 2026

Okay, rebased and fixed test

@ChayimFriedman2 ChayimFriedman2 added this pull request to the merge queue Feb 4, 2026
Merged via the queue into rust-lang:master with commit 1433910 Feb 4, 2026
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 4, 2026
@A4-Tacks A4-Tacks deleted the comp-not-in-cond branch February 5, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants