Skip to content

svelte: Use @poppanator/sveltekit-svg for inline SVG support #12505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Turbo87 merged 2 commits into from
Dec 15, 2025
Merged

svelte: Use @poppanator/sveltekit-svg for inline SVG support #12505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2978772
svelte: Use `@poppanator/sveltekit-svg` for inline SVG support
Turbo87 Dec 13, 2025
8b94a80
svelte/Header: Add lock icon
Turbo87 Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 86 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions svelte/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"@eslint/compat": "2.0.0",
"@eslint/js": "9.39.1",
"@ianvs/prettier-plugin-sort-imports": "4.7.0",
"@poppanator/sveltekit-svg": "^6.0.1",
"@sveltejs/adapter-static": "3.0.10",
"@sveltejs/kit": "2.49.2",
"@sveltejs/vite-plugin-svelte": "6.2.1",
Expand Down
2 changes: 2 additions & 0 deletions svelte/src/app.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import '@poppanator/sveltekit-svg/dist/svg.d.ts';

// See https://svelte.dev/docs/kit/types#app.d.ts
// for information about these interfaces
declare global {
Expand Down
3 changes: 3 additions & 0 deletions svelte/src/lib/assets/lock.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 3 additions & 5 deletions svelte/src/lib/components/Header.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import { resolve } from '$app/paths';

import logo from '$lib/assets/cargo.png';
import LockIcon from '$lib/assets/lock.svg?component';

// TODO: import ColorSchemeMenu from './ColorSchemeMenu.svelte';
// TODO: import Dropdown from './Dropdown.svelte';
Expand All @@ -10,7 +11,6 @@
// TODO: import UserAvatar from './UserAvatar.svelte';

// TODO: import session service
// TODO: import lock icon SVG

interface Props {
hero?: boolean;
Expand Down Expand Up @@ -57,7 +57,7 @@
<!-- <Dropdown data-test-user-menu> ... </Dropdown> -->
<!-- {:else} -->
<button type="button" class="login-button button-reset" data-test-login-button>
<!-- TODO: add lock icon -->
<LockIcon />
Log in with GitHub
</button>
<!-- {/if} -->
Expand Down Expand Up @@ -245,13 +245,11 @@
*/
}

/* TODO: uncomment when lock icon is added
.login-icon {
.login-button :global(svg) {
width: 1em;
margin-right: var(--space-2xs);
opacity: 0.5;
}
*/

/* TODO: uncomment when UserAvatar is implemented
.avatar {
Expand Down
3 changes: 2 additions & 1 deletion svelte/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import svg from '@poppanator/sveltekit-svg';
import { sveltekit } from '@sveltejs/kit/vite';
import { playwright } from '@vitest/browser-playwright';
import { defineConfig } from 'vitest/config';

export default defineConfig({
plugins: [sveltekit()],
plugins: [sveltekit(), svg()],

test: {
expect: { requireAssertions: true },
Expand Down
Loading