svelte: Replace Svelte favicon with the original from the Ember.js app #12503
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
Turbo87
force-pushed
the
svelte-favicon
branch
from
24e512c to
b412cf8
Compare
We're putting the file into `/static` (instead of importing from `$lib/assets`) to ensure that the file is available at the root path for clients that just assume the URL instead of parsing the HTML for the right path.
Turbo87
force-pushed
the
svelte-favicon
branch
from
b412cf8 to
6b8c5ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're putting the file into
/static(instead of importing from$lib/assets) to ensure that the file is available at the root path for clients that just assume the URL instead of parsing the HTML for the right path.Related