-
Notifications
You must be signed in to change notification settings - Fork 683
Initial stab at a security tab showing advisories #12311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
118a13c to
0ad81ca
Compare
|
I've implemented Markdown formatting with GitHub-flavored Markdown support for the advisory details. Seems like a decent MVP from which we can iterate further? |
Turbo87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a good start! 👍
one more suggestion that did not fit into the diff: we should add tests for this new feature to https://github.com/rust-lang/crates.io/tree/main/e2e/acceptance. at least one test for displaying 2+ advisories, one for the empty state, and one for the rustsec server returning e.g. a 500 error. we use msw for network mocking, which should make it relatively straight-forward to implement. it's probably sufficient to implement the msw request handlers in the tests instead of creating a generic handler in the crates-io-msw package.
4aa6fdf to
a6f7be2
Compare
Here's my first take at implementing the security tab as proposed in RFC 3872. Resolves #12507.
This is intentionally light on details to get an initial review on my first baby Ember.js steps. Not sure how much we need to add before this gets merged.
Keeping as draft while the RFC has not been merged.