Use ControlFlow in fold_while implementation#1107
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1107 +/- ##
==========================================
- Coverage 94.38% 93.93% -0.46%
==========================================
Files 48 52 +4
Lines 6665 6679 +14
==========================================
- Hits 6291 6274 -17
- Misses 374 405 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scottmcm
commented
May 25, 2026
| F: FnMut(B, Self::Item) -> FoldWhile<B>, | ||
| { | ||
| use Result::{Err as Break, Ok as Continue}; | ||
| use core::ops::ControlFlow::{Break, Continue}; |
Contributor
Author
There was a problem hiding this comment.
No idea how this could change the code coverage...
phimuemue
approved these changes
May 26, 2026
Merged
via the queue into
rust-itertools:master
with commit May 26, 2026
86ec635
13 of 14 checks passed
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the MSRV is high enough, might as well.
(inspired by #1106 (comment))