Bumped a few crates, ran cargo update#673
Bumped a few crates, ran cargo update#673martinfrances107 wants to merge 1 commit intorust-cli:mainfrom
Conversation
-ron = { version = "0.8", optional = true }
+ron = { version = "0.10", optional = true }
-convert_case = { version = "0.6", optional = true }
+convert_case = { version = "0.8", optional = true }
-notify = "7.0"
+notify = "8.1"
| rust-version = "1.75.0" # MSRV | ||
| include = [ | ||
| "build.rs", | ||
| "src/**/*", | ||
| "Cargo.toml", | ||
| "Cargo.lock", | ||
| "LICENSE*", | ||
| "README.md", | ||
| "examples/**/*" | ||
| "examples/**/*", |
There was a problem hiding this comment.
There seem to be unrelated changes
| json5_rs = { version = "0.4", optional = true, package = "json5" } | ||
| indexmap = { version = "2.10.0", features = ["serde"], optional = true } | ||
| convert_case = { version = "0.6", optional = true } | ||
| convert_case = { version = "0.8", optional = true } |
There was a problem hiding this comment.
This is a breaking change and we'd need to handle this more conciously
| yaml-rust2 = { version = "0.10", optional = true } | ||
| rust-ini = { version = "0.21", optional = true } | ||
| ron = { version = "0.8", optional = true } | ||
| ron = { version = "0.10", optional = true } |
There was a problem hiding this comment.
We are not ready to upgrade ron, see #476 (review)
|
|
||
| glob = "0.3" | ||
| notify = "7.0" | ||
| notify = "8.1" |
There was a problem hiding this comment.
This requires an MSRV bump. The question is whether its worth it for a dev dependency
There was a problem hiding this comment.
isn't it possible to have a higher MSRV for dev-deps? glob seem to have it: https://github.com/rust-lang/glob/blob/master/.github/workflows/rust.yml
There was a problem hiding this comment.
Yes, but then you can't run tests and verify the behavior under MSRV, see also https://doc.rust-lang.org/cargo/reference/rust-version.html#support-expectations
3 participants
-ron = { version = "0.8", optional = true }
+ron = { version = "0.10", optional = true }
-convert_case = { version = "0.6", optional = true }
+convert_case = { version = "0.8", optional = true }
-notify = "7.0"
+notify = "8.1"