Merged
Conversation
Member
Author
|
I have also added the 8.0.0 milestone to the PRs that are blocking |
This was referenced Sep 29, 2022
sanket1729
added a commit
that referenced
this pull request
Oct 1, 2022
9a57e00 Ensure there are no duplicated leaf hashes in `tap_key_origins` (Alekos Filini) 1bbd13b Allow `non_witness_utxo` for segwit PSBTs (Alekos Filini) 9f63165 Append bip32 derivations instead of replacing the map entirely (Alekos Filini) f46830c Add tests for `PsbtExt::update_output_with_descriptor` (Alekos Filini) 3148fb3 Correct error description for `UtxoUpdateError::MissingInputUtxo` (Alekos Filini) 03c25ec Add `PsbtOutputExt::update_with_descriptor` (Alekos Filini) Pull request description: This essentially mirrors `PsbtInputExt::update_with_descriptor` but it works on PSBT outputs. To avoid code duplication, the current logic that deals with PSBT inputs has been generalized to handle both input and outputs with a new internal `PsbtFields` trait. ----- I hope it's not too late to get this PR in the new 8.0 release (cc #462) ACKs for top commit: apoelstra: ACK 9a57e00 sanket1729: ACK 9a57e00. Not completely happy with internal trait abstraction. I may work on a future PR to abstract that into a function that takes 1) script pubkey and 2) descriptor and outputs the relevant fields that are added to the psbt. Tree-SHA512: 595485b8aa6db665a120ff756c522b8e81858c06bf86dbda25e5b742f10ad537481351c0111b5f0946919f90f7784c8ff2c2e99b9f403f4607723f46ac608d38
Contributor
|
What do you think of sneaking in #470 too? It breaks some APIs hence needs a major version bump. |
Member
|
I wouldn't mind getting #470 in. Yes, it's only a draft and may change, but we've got a bunch of other stuff in this library that's also subject to change (and a lot of stuff which is not specced out very well, or at all). We definitely did 1.0 years too early here :) |
sanket1729
force-pushed
the
8.0.0
branch
2 times, most recently
from
50b6bc5 to
87949cc
Compare
Member
Author
Member
Author
|
@apoelstra, perhaps #475 can be merged? |
apoelstra
approved these changes
Oct 19, 2022
sanket1729
added a commit
to sanket1729/elements-miniscript
that referenced
this pull request
Oct 21, 2022
…022_10 fd9ef55 (bitcoin-upstream/master) Merge rust-bitcoin/rust-miniscript#462: Release 8.0.0
notmandatory
added a commit
to bitcoindevkit/bdk
that referenced
this pull request
Oct 27, 2022
c7a43d9 Remove unused code (Alekos Filini) 1ffd59d Upgrade to rust-bitcoin 0.29 (Alekos Filini) ae4f4e5 Upgrade `rand` to `0.8` (Alekos Filini) 9854fd3 Remove deprecated address validators (Alekos Filini) Pull request description: ### Description Upgrade BDK to rust-bitcoin 0.29 Missing pieces: - [x] rust-miniscript `update_output_with_descriptor` - rust-bitcoin/rust-miniscript#465 - [x] rust-miniscript 8.0.0 release - rust-bitcoin/rust-miniscript#462 - [x] Upgrade rust-hwi to bitcoin 0.29 bitcoindevkit/rust-hwi#50 - [x] Upgrade esplora-client to bitcoin 0.29 bitcoindevkit/rust-esplora-client#20 - [x] Upgrade rand to 0.8 like secp256k1 did ### Notes to the reviewers The commits still need to be reordered and cleaned up ### Changelog notice - Upgrade rust-bitcoin to 0.29 - Remove deprecated "address validators" ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: notmandatory: ACK c7a43d9 Tree-SHA512: 718a1baf3613b31ec1de39fe63467ebee38617963a4ce0670a617e20fe4f46a57c5786933cdde6cfad9fc76ce0af08843f58844fb4a89f5948cb42c697f802ef
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
3f451db9a8b00b88ca8b7b6fe0334707efe8d88c Release 8.0.0 (sanket1729)
Pull request description:
Draft release PR. Still blocked on reviews of
1) #418
2) #450
3) #461
ACKs for top commit:
apoelstra:
ACK 3f451db9a8b00b88ca8b7b6fe0334707efe8d88c
Tree-SHA512: aa455fd57a894b1edb49b6273126a05c9d0897ca50ee572fa8a59b4d2a96e2013f2ed9ec4b96cd5e449ba5b5ee6bd32aa57da110df69bd35b8a970ccb1440002
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft release PR. Still blocked on reviews of