Skip to content

Release tracking PR: jsonrpc v0.19.0#408

Merged
tcharding merged 3 commits intorust-bitcoin:masterfrom
tcharding:push-znwvuypznnzl
Jan 6, 2026
Merged

Release tracking PR: jsonrpc v0.19.0#408
tcharding merged 3 commits intorust-bitcoin:masterfrom
tcharding:push-znwvuypznnzl

Conversation

@tcharding
Copy link
Member

@tcharding tcharding commented Oct 30, 2025 •
edited
Loading

Do a couple of minor cleanups then do the release patch - version bump, changelog, and lock files.

@tcharding tcharding changed the title Push znwvuypznnzl Release tracking PR: jsonrpc v0.19.0 Oct 30, 2025
@jamillambert
Copy link
Collaborator

jamillambert commented Oct 31, 2025

Reviewed 52c02b3, all good.

@tcharding
jsonrpc: Update repository in manifest
60915f2 
Currently lists the repository name from before we did the `corepc`
rename. Note this was never released, as such crates.io still points
at Andrew's repo.
@tcharding
jsonrpc: Grab missing changelog
7b54dda 
When we moved this crate from Andrew's repo somehow I forgot to bring
over the `CHANGELOG.md` file. Copy it from the original repo (now
archived).

https://github.com/apoelstra/rust-jsonrpc/blob/master/CHANGELOG.md
@tcharding
jsonrpc: Bump version to 0.19.0
d3e73a7 
In preparation for release bump the version number, add a changelog
entry, and update the lock files.
@tcharding tcharding marked this pull request as ready for review November 5, 2025 21:44
@tcharding
Copy link
Member Author

tcharding commented Nov 5, 2025

@apoelstra do you want to do the release of jsonrpc or do you want to add me as an owner on crates.io and I can take care of it?

jamillambert
jamillambert approved these changes Nov 6, 2025
View reviewed changes
Copy link
Collaborator

@jamillambert jamillambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d3e73a7

@tcharding
Copy link
Member Author

tcharding commented Nov 9, 2025

@apoelstra we want to do a new release of all these crates with Core v30 support soon. Sorry to break your balls but can you take a few minutes to think about this one please?

@tcharding
Copy link
Member Author

tcharding commented Nov 18, 2025

Breaking your balls just to bubble this PR a bit higher up your priority list please @apoelstra.

With the current state of master we are blocked on releasing corepc-client (and corepc-node) because of this PR. Which means the corepc-types v0.11.0 is not usable (with Core v30 support).

We have two choices:

  1. Revert the jsonrpc depends on bitreq change
  2. Merge and release this PR

Its not super urgent but if we can I'd prefer to do (2).

@tcharding tcharding mentioned this pull request Nov 18, 2025
Merged
@oleonardolima oleonardolima mentioned this pull request Dec 19, 2025
Closed
@tcharding
Copy link
Member Author

tcharding commented Jan 1, 2026 •
edited
Loading

@apoelstra can I have publish perms for jsonrpc please so we can push this forward. Alternatively I added you as admin to this repo, so you can also just merge this and release jsonrpc yourself since the crate already has three owners you don't really need me there also.

@apoelstra
Copy link
Member

apoelstra commented Jan 5, 2026

Hi, sorry, I did not see this at all. "Release tracking PR" and "corepc" sounded like things that had nothing to do with me. In future feel free to ping me on signal if you need my attention in this repo.

@tcharding tcharding merged commit 1bc85a2 into rust-bitcoin:master Jan 6, 2026
30 checks passed
@tcharding
Copy link
Member Author

tcharding commented Jan 6, 2026

Tagged and published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamillambert jamillambert jamillambert approved these changes

Assignees

No one assigned

Labels

C-client C-jsonrpc C-node C-types

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tcharding @jamillambert @apoelstra