fix: map unmapped reads (tid=-1) to correct index in slow_idxstats#511
Open
nh13 wants to merge 1 commit intorust-bio:masterfrom
Open
fix: map unmapped reads (tid=-1) to correct index in slow_idxstats#511nh13 wants to merge 1 commit intorust-bio:masterfrom
nh13 wants to merge 1 commit intorust-bio:masterfrom
Conversation
Pull Request Test Coverage Report for Build 23730666310Details
💛 - Coveralls |
When iterating CRAM records, unmapped reads have tid == -1. Casting this to usize wraps to usize::MAX, causing an index-out-of-bounds panic. Map tid == -1 to the designated unmapped slot at index nref.
0d961ac to
7967059
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When iterating CRAM records, unmapped reads have tid == -1. Casting
this to usize wraps to usize::MAX, causing an index-out-of-bounds
panic. Map tid == -1 to the designated unmapped slot at index nref.