Macro-less variants of expect and expect_file#32
Open
jeremyBanks wants to merge 4 commits intorust-analyzer:masterfrom
Open
Macro-less variants of expect and expect_file#32jeremyBanks wants to merge 4 commits intorust-analyzer:masterfrom
expect and expect_file#32jeremyBanks wants to merge 4 commits intorust-analyzer:masterfrom
Conversation
7fb3917 to
bf056e6
Compare
expect_fileexpect and expect_file
expect and expect_fileexpect and expect_file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the macro-less variants of
expectandexpect_fileusing#[track_caller]as described in #15.The compatibility concern with other functions using
#[track_caller]raised in #15 (comment) is noted in the documentation. This isn't entirely a disadvantage; users can write certain wrapper functions with#[track_caller]like they might previously have written wrapper macros:This requires bumping the MSRV, but only by one release (1.45.0 to 1.46.0).