feat(spl): simplify rent minimum_balance float calculation #903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a K rule to directly simplify the rent exemption threshold pattern `(int)((float)PRODUCT * 2.0)` to `PRODUCT * 2`, avoiding intermediate float thunks during symbolic execution.
jberthold
approved these changes
Dec 19, 2025
Comment on lines
545
to
548
| thunk(#cast(Integer(PRODUCT:Int, 64, false), castKindIntToFloat, _TY1, _TY2)), | ||
| Float(0.20000000000000000e1, 64), | ||
| false)), | ||
| castKindFloatToInt, _TY3, _TY4) |
Member
There was a problem hiding this comment.
Maybe the TY s could be connected here? Would it usually be a round-trip cast? (I guess so because the Ints will typically all be u64 in this codebase)
Suggested change
| thunk(#cast(Integer(PRODUCT:Int, 64, false), castKindIntToFloat, _TY1, _TY2)), | |
| Float(0.20000000000000000e1, 64), | |
| false)), | |
| castKindFloatToInt, _TY3, _TY4) | |
| thunk(#cast(Integer(PRODUCT:Int, 64, false), castKindIntToFloat, INT_TY, FLOAT_TY)), | |
| Float(0.20000000000000000e1, 64), | |
| false)), | |
| castKindFloatToInt, FLOAT_TY, INT_TY) |
FLOAT_TY should definitely be the same here. INT_TY could be different but I don't think it will be in practice
Contributor
Author
There was a problem hiding this comment.
I can add it, but I don't think it's necessary. It's a specific rule for spl-token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a K rule to directly simplify the rent exemption threshold pattern
(int)((float)PRODUCT * 2.0)toPRODUCT * 2, avoiding intermediate float thunks during symbolic execution.