fix(spl): update the unpack cheatcode for rent #902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jberthold
approved these changes
Dec 18, 2025
Member
jberthold
left a comment
jberthold
left a comment
There was a problem hiding this comment.
LGTM. Maybe we can mention the Rent unpack function in the code comment in section "Pack / Unpack operations" https://github.com/runtimeverification/mir-semantics/pull/902/files#diff-61b6702ab06885df94cc6a1265abcc4435ab4a4e7083995dd9e4abd0d17346cdR437
Update documentation and code comments to accurately reflect that Rent deserialization uses bincode::deserialize rather than Rent::unpack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_spltoken_domain_datain spl-token