Skip to content

Decompose multisig signer pubkeys for p-token#1018

Merged
automergerpr-permission-manager[bot] merged 1 commit intofeature/p-tokenfrom
mk/pubkey-list-smt-timeout-ptoken
Apr 8, 2026
Merged

Decompose multisig signer pubkeys for p-token#1018
automergerpr-permission-manager[bot] merged 1 commit intofeature/p-tokenfrom
mk/pubkey-list-smt-timeout-ptoken

Conversation

@mariaKt
Copy link
Copy Markdown
Collaborator

@mariaKt mariaKt commented Apr 7, 2026

Similar to #1000, but for p-token.

I noticed the new tests for 3 signers failing to prune paths with contradictory conditions: a specific tx_signer key already has a byte-by-byte key mismatch with a registered signer key, but then due to the signer being represented as a List , the same comparison is re-evaluated using ?Signer0:List (opaque) against the same tx_signer bytes, with ==K being opaque.

@mariaKt mariaKt force-pushed the mk/pubkey-list-smt-timeout-ptoken branch from 254a48d to 1ded91b Compare April 7, 2026 14:32
@mariaKt mariaKt marked this pull request as ready for review April 7, 2026 17:04
@mariaKt mariaKt marked this pull request as draft April 7, 2026 17:04
@mariaKt
Copy link
Copy Markdown
Collaborator Author

mariaKt commented Apr 7, 2026

I have tested this with a few p-token proofs, though not all (my machine cannot run many proofs in parallel). The proofs with 1 tx_signer pass:

  • approve, withdraw_excess_lamports_multisig: these do not exercise the changes, just checking a couple to be safe
  • initialize_multisig, initialize_multisig2: these use cheatcode_is_multisig
  • approve_multisig, approve_checked_multisig, withdraw_excess_lamports_multisig_multisig, revoke_multisig: these use 'cheatcode_is_multisig' and test the decomposed pubkeys through key comparisons in validate_owner
    I am waiting on the results of one the new tests with 3 tx_signer (using the additional fix here locally). I will run more after the 3 signer proof is done.

@mariaKt mariaKt marked this pull request as ready for review April 8, 2026 00:53
@mariaKt mariaKt requested review from Stevengre and dkcumming April 8, 2026 00:53
Copy link
Copy Markdown
Contributor

@Stevengre Stevengre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariaKt mariaKt force-pushed the mk/pubkey-list-smt-timeout-ptoken branch from 1ded91b to 05776a7 Compare April 8, 2026 15:06
@automergerpr-permission-manager automergerpr-permission-manager bot merged commit d19c66d into feature/p-token Apr 8, 2026
19 of 22 checks passed
@automergerpr-permission-manager automergerpr-permission-manager bot deleted the mk/pubkey-list-smt-timeout-ptoken branch April 8, 2026 17:22
mariaKt added a commit to runtimeverification/solana-token that referenced this pull request Apr 9, 2026
Update mir-semantics submodule to latest feature/p-token
(d19c66d2aa74c852c5e9d98038864678986d8447)

- Decompose multisig signer pubkeys for p-token
([#1018](runtimeverification/mir-semantics#1018))
- ci(stable-mir-ui): make manual UI workflow runnable
([#975](runtimeverification/mir-semantics#975))
- Increased timeout of Haskell Exec SMIR CI test
([#1021](runtimeverification/mir-semantics#1021),
[#1023](runtimeverification/mir-semantics#1023))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants