test: enable --terminate-on-thunk for all prove tests#1009
Merged
automergerpr-permission-manager[bot] merged 4 commits intomasterfrom Apr 2, 2026
Merged
test: enable --terminate-on-thunk for all prove tests#1009automergerpr-permission-manager[bot] merged 4 commits intomasterfrom
automergerpr-permission-manager[bot] merged 4 commits intomasterfrom
Conversation
Make --terminate-on-thunk the default for all prove tests instead of per-test opt-in. This exposes unresolved thunks (from incomplete semantics) that were previously silently propagated. All 110 prove tests pass with this change on master. Update 13 show expected files whose proof trees changed due to earlier thunk termination. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 67c8ab37f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dkcumming
approved these changes
Apr 2, 2026
Collaborator
dkcumming
left a comment
dkcumming
left a comment
There was a problem hiding this comment.
Awesome! Let's give this a go, and if it works out we should consider removing thunk alltoghter
automergerpr-permission-manager
bot
deleted the
test/terminate-on-thunk-default
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--terminate-on-thunkthe default for all prove tests instead of per-test opt-in viaPROVE_TERMINATE_ON_THUNKContext
First introduced in PR #813,
--terminate-on-thunkmakes the prover treat anythunk(...)in the K cell as a terminal state, immediately stopping proof exploration. Previously onlyclosure-stagedopted in. Enabling it globally ensures we catch any test that silently relies on thunk propagation.Test plan
test_proveparametrizations pass locally🤖 Generated with Claude Code