Fix branch for installed packages #133
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kuploads a list of packages that it manages augmented with information from respectively installed packages . Previously, when a package that is managed bykupis also installed on the users system, the release branch information was lost.This caused
kup installto always install the latest version of the master branch, when the package was already installed. Note:kup updateis an alias forkup install. When the release branch of a given package is not the master branch, e.g. for kontrol, then akup installoperation always built the package from source instead of fetching from cache.The
kup listandkup list [package]operations were also broken due to this. In case ofkup list, a package was marked as not up-to-date when the respective non-release master branch was installed due to the previously described bug.kup list [package]on the other hand was broken as long as the respective package was installed, as the release branch information got lost, when the package had a release branch different from the master branch.On another note, the branch that is printed when installing a package without specifically stating a version to install was always
master, despite the installed release branch potentially being different.This pull request fixes the information loss and therefore fixes several bugs/inconsistencies observed with
kup install,kup list, andkup list [package]. Also, the branch that is printed now always properly reflects the actual branch that is installed.