Closed
Conversation
Member
|
unprivate your repo please |
Author
Working on it, It shows the repo is public not sure if it takes a while to propagate |
Author
|
Ok good now, just a simple spelling error.. |
Contributor
|
Not sure if its my spot; but i saw some heavy use of reflection in the plugin code. Seeing as it being listed on Runelite#forbidden-language-features you might need to rework some stuff. |
Author
Thanks for pointing this out. I am going to see if I can't rework this. |
|
Internal use only: Reviewer details Maintainer details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ctrl+right-click any overlay to open that plugin's settings in the side panel or a popup dialog.