Skip to content

Add DoomValueAdjustment plugin manifest#10885

Merged
pajlada merged 5 commits intorunelite:masterfrom
joffewilliam:DoomValueAdj
Mar 8, 2026
Merged

Add DoomValueAdjustment plugin manifest#10885
pajlada merged 5 commits intorunelite:masterfrom
joffewilliam:DoomValueAdj

Conversation

@joffewilliam
Copy link
Copy Markdown
Contributor

@joffewilliam joffewilliam commented Mar 5, 2026

Hey guys,
Doom Value Adjustment is a plugin that fixes the end of delve loot window valuation at Doom by treating Sun-kissed bones as 0 GP instead of the incorrect 8,000 GP each. This obviously only adjusts the client side displayed loot value.

Jagex currently assigns Sun-kissed bones (item ID 29378) a value of 8,000 GP, which heavily inflates the total loot value shown in the Doom loot window.

This plugin simply corrects that by subtracting the bogus bone value from the final displayed total. Jagex has known about this issue since release and still hasn't fixed it. So I figured a plugin was a good solution since it looks like it's here to stay.

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app bot commented Mar 5, 2026

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app bot commented Mar 5, 2026

Internal use only: Reviewer details Maintainer details

@pajlada
Copy link
Copy Markdown
Contributor

pajlada commented Mar 8, 2026

Hi, thanks for your plugin submission.

Please remove your DoomValueAdjustmentConfig since it's unused.

You can make use of the gameval package in runelite instead of keeping a list of IDs yourself.

SUN_KISSED_BONES_ITEM_ID is ItemID.SUN_KISSED_BONE
DOOM_GROUP_ID is InterfaceID.DOM_END_LEVEL_UI
DOOM_GROUP_ID with LOOT_VALUE_CHILD_ID is InterfaceID.DomEndLevelUi.LOOT_VALUE
DOOM_GROUP_ID with LOOT_CONTENTS_CHILD_ID is InterfaceID.DomEndLevelUi.LOOT_CONTENTS

@pajlada pajlada added the waiting for author waiting for the pr author to make changes or respond to questions label Mar 8, 2026
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Mar 8, 2026
@pajlada
Copy link
Copy Markdown
Contributor

pajlada commented Mar 8, 2026

@pajlada pajlada added the waiting for author waiting for the pr author to make changes or respond to questions label Mar 8, 2026
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Mar 8, 2026
@joffewilliam
Copy link
Copy Markdown
Contributor Author

I gotcha now. Sorry about that.

@pajlada pajlada merged commit 9229c9c into runelite:master Mar 8, 2026
3 checks passed
CCatRS pushed a commit to CCatRS/plugin-hub that referenced this pull request Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants