fix: update CSV file generators for topic tags#645
Merged
dmitrytrager merged 2 commits intomainfrom Apr 7, 2026
Merged
Conversation
Since tags are not language agnostic we do not use #tags_on function anymore. Language scope for content works via topics only and for topics we now use #taggings and #tag_list functions
dcollie2
reviewed
Apr 7, 2026
| @@ -14,13 +14,13 @@ def headers | |||
|
|
|||
| def scope | |||
| language.topics.active.includes(:tags) | |||
Collaborator
There was a problem hiding this comment.
Would this prevent n+1?
includes(taggings: :tag)
Same for the topic_tags generator.
dcollie2
approved these changes
Apr 7, 2026
Collaborator
dcollie2
left a comment
dcollie2
left a comment
There was a problem hiding this comment.
I suggested an N+1 related change but this will work with or without that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since tags are not language agnostic we do not use #tags_on function anymore. Language scope for content works via topics only and for topics we now use #taggings and #tag_list functions
What Issue Does This PR Cover, If Any?
Resolves issue when Spanish topic has tags but tag csv files for Spanish do not have these tags
What Changed? And Why Did It Change?
How Has This Been Tested?
Please Provide Screenshots
Additional Comments