Add item filter to donations index page#5492
Open
costajohnt wants to merge 1 commit intorubyforgood:mainfrom
Open
Add item filter to donations index page#5492costajohnt wants to merge 1 commit intorubyforgood:mainfrom
costajohnt wants to merge 1 commit intorubyforgood:mainfrom
Conversation
Add by_item_id and by_item_category_id scopes to Donation model, mirroring the existing Distribution filters. Wire up the item filter dropdown on the donations index page and permit the new params in both the controller and the View::Donations data object. Closes rubyforgood#5105
9395a77 to
3e2f4fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
by_item_idandby_item_category_idscopes to theDonationmodel, mirroring the existing scopes onDistributionfilter_selecthelperDonationsController#filter_paramsandView::Donations.filter_paramsCloses #5105
Approach
Followed the pattern established by the Distribution model's
by_item_idscope (line 54 ofdistribution.rb) and the Distribution index page's item filter dropdown. TheFilterableconcern'sclass_filtermethod handles scope chaining automatically.Files changed
app/models/donation.rbby_item_idandby_item_category_idscopesapp/models/view/donations.rbitemsto Data.define, permit new filter params, addselected_itemaccessorapp/controllers/donations_controller.rb:by_item_idand:by_item_category_idinfilter_paramsapp/views/donations/index.html.erbspec/models/donation_spec.rbby_item_idandby_item_category_idspec/system/donation_system_spec.rbTest plan
by_item_idreturns only donations containing the specified itemby_item_category_idreturns only donations with items in the specified categoryclass_filter)