Skip to content

Fix Jest test failures caused by Node 24 / jsdom incompatibilities #6826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
compwron merged 2 commits into from
Apr 8, 2026
+7 −9
Merged

Fix Jest test failures caused by Node 24 / jsdom incompatibilities #6826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
609f026
Fix window.location mock incompatibility with Node 24 jsdom
cliftonmcintosh Apr 5, 2026
1aa0325
Fix CSS color assertion incompatibility with Node 24 jsdom
cliftonmcintosh Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions app/javascript/__tests__/two_minute_warning_session_timeout.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,8 @@ describe('session_timeout_poller', () => {
mockAlert = jest.fn()
mockReload = jest.fn()
global.alert = mockAlert
Object.defineProperty(window, 'location', {
writable: true,
value: { reload: mockReload }
})
delete window.location
window.location = { reload: mockReload }

// Set a short timeout for testing (in minutes)
originalTimeout = global.window.timeout
Expand Down
10 changes: 5 additions & 5 deletions app/javascript/__tests__/validated_form.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,12 @@ describe('NonDrivingContactMediumWarning', () => {
$(() => {
try {
expect(checkboxContainer.css('background-color')).not.toBe('rgb(255, 248, 225)')
expect(milesDrivenInput.css('border')).not.toBe('2px solid #ffc107')
expect(milesDrivenInput.css('border')).not.toBe('2px solid rgb(255, 193, 7)')

component.warningHighlightUI('A warning message')

expect(checkboxContainer.css('background-color')).toBe('rgb(255, 248, 225)')
expect(milesDrivenInput.css('border')).toBe('2px solid #ffc107')
expect(milesDrivenInput.css('border')).toBe('2px solid rgb(255, 193, 7)')
done()
} catch (error) {
done(error)
Expand All @@ -163,17 +163,17 @@ describe('NonDrivingContactMediumWarning', () => {
$(() => {
try {
expect(checkboxContainer.css('background-color')).not.toBe('rgb(255, 248, 225)')
expect(milesDrivenInput.css('border')).not.toBe('2px solid #ffc107')
expect(milesDrivenInput.css('border')).not.toBe('2px solid rgb(255, 193, 7)')

component.warningHighlightUI('A warning message')

expect(checkboxContainer.css('background-color')).toBe('rgb(255, 248, 225)')
expect(milesDrivenInput.css('border')).toBe('2px solid #ffc107')
expect(milesDrivenInput.css('border')).toBe('2px solid rgb(255, 193, 7)')

component.warningHighlightUI()

expect(checkboxContainer.css('background-color')).not.toBe('rgb(255, 248, 225)')
expect(milesDrivenInput.css('border')).not.toBe('2px solid #ffc107')
expect(milesDrivenInput.css('border')).not.toBe('2px solid rgb(255, 193, 7)')

done()
} catch (error) {
Expand Down
Loading