Open
Conversation
wthurston
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
github-actions
bot
added
the
dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #6706
What changed, and why?
This updates the project Ruby version from 3.3.8 to 3.3.10. This patch-level upgrade should not contain any breaking changes. I am interested in doing this in pursuit of getting Codespace dev setup working smoothly again. Note that this does not entirely resolve the problems with using the Codespaces button setup to develop - some more adjustments will be needed, but updating to 3.3.10 and bumping up the Ruby docker image we are using in the container is a first step toward this.
So to reiterate - if you try to run this branch in Codespaces, you will still have issues, just like right now on
main, but I am planning on continuing to chip away at these to get Codespace usage into a good state!How is this tested? (please write rspec and jest tests!) 💖💪
Note: if you see a flake in your test build in github actions, please post in slack #casa "Flaky test: " :) 💪
Note: We love capybara tests! If you are writing both haml/js and ruby, please try to test your work with tests at every level including system tests like https://github.com/rubyforgood/casa/tree/main/spec/system
I have run the rspec and npm test suites. I have got the app up and running in a Codespace (this takes a bit of additional manual setup work due to issues in the setup script) and tested signing in as various user types and navigating around the app.
Note: if reviewers could run the RSpec test suite locally that would be great - some of the specs fail due to not being able to use Chrome/Selenium in Codespaces and I have not had a chance to run the Codespace in local VSCode or otherwise clone the app locally outside of Codespaces.
This is my first PR here so my apologies if I am missing anything!