Align select and remote-select heights with input height#1528
Merged
Conversation
Native selects with a placeholder were rendering shorter because .select-placeholder shrinks font-size to 0.875rem without pinning line-height, so the box compressed. TomSelect controls were also slightly shorter since the inner control had min-height: 0 and the input's line-height wasn't pinned. Lock line-height to 1.5rem on .select-placeholder and on TomSelect's .ts-control / inner input / .item so all variants line up at the standard input height.
jmilljr24
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
Windows audienceselect was shortest, theWorkshopTomSelect was slightly taller, and the populatedOrganizationselect was the tallest. They should all match the standard input height.How did you approach the change?
line-height: 1.5remonselect.select-placeholderso the smaller placeholder font (0.875rem) no longer collapses the box, keeping empty selects the same height as populated ones.remote_select_controller.js, replaced themin-height: 0reset on.ts-controlwithmin-height: 1.5remand pinnedline-height: 1.5remon the control, the inner input, and.itemso TomSelect's content box matches a single line oftext-base. Combined with the wrapper's existingpy-2and border, total height ends up at the same 42px as a native input.UI Testing Checklist
/story_ideas/new, theWindows audience,Workshop(TomSelect), andOrganizationcontrols all sit at the same height as the surrounding text inputs, both empty and after a value is selected.remote-select(event registrations, workshop variations, story form, people/organization affiliations) still render correctly.Anything else to add?
🤖 Generated with Claude Code