Handle blocked organization deletion gracefully#1526
Merged
Conversation
Deleting an organization with associated affiliations, workshop logs, or other related records produced a 500. The action now surfaces a friendly alert and keeps the user on the organization page so they can resolve the blocking associations before retrying. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The edit page is where admins manage affiliations and other associations that block deletion, so sending them there on failure puts them next to the controls they need. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1497
What is the goal of this PR and why is this important?
How did you approach the change?
OrganizationsController#destroynow usesdestroy(instead ofdestroy!) sorestrict_with_errorvalidations fromaffiliationsandevent_registration_organizationssurface as flash alertsrescue ActiveRecord::InvalidForeignKeyto catch DB-level FK constraint violations from associations not covered bydependent:(workshop_logs, reports, stories, story_ideas, community_news, monthly_reports, workshop_variations, workshop_variation_ideas, users)UI Testing Checklist
Anything else to add?
UsersController#destroyand the Rails scaffold