Skip to content

Remove old assets v2#1041

Open
maebeale wants to merge 5 commits intomainfrom
remove-old-assets-v2
Open

Remove old assets v2#1041
maebeale wants to merge 5 commits intomainfrom
remove-old-assets-v2

Conversation

@maebeale
Copy link
Collaborator

  • This work Closes [link an issue]

What is the goal of this PR and why is this important?

  • Bringing this work back to the fore. Ditching the old PR bc it's stale. This cherry picks commits.

How did you approach the change?

Anything else to add?

maebeale and others added 2 commits February 15, 2026 20:26
- Fix people form: data_method/data_confirm → turbo_method/turbo_confirm
- Fix devise registration: confirm → turbo_confirm
- Fix workshop ideas: confirm → turbo_confirm (also fix duplicate message text)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
import "@rails/activestorage"
import * as ActiveStorage from "@rails/activestorage";
ActiveStorage.start();

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calling out again that we're now loading active storage here.

@@ -34,6 +34,6 @@

<h3>Cancel my account</h3>

<p>Unhappy? <%= button_to "Cancel my account", registration_path(resource_name), data: { confirm: "Are you sure?" }, method: :delete %></p>
<p>Unhappy? <%= button_to "Cancel my account", registration_path(resource_name), data: { turbo_confirm: "Are you sure?" }, method: :delete %></p>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing to turbo methods throughout

@@ -11,9 +11,6 @@
# Precompile additional assets.
# application.js, application.css, and all non-JS/CSS in the app/assets
# folder are already added.
Rails.application.config.assets.precompile += %w[ admin.js admin.css foundation_emails.css ]
Rails.application.config.assets.precompile += %w[awbw/foundation_emails-20250913.css]

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove call to compile old assets

maebeale and others added 3 commits February 15, 2026 20:48
- Remove broken @font-face for deleted Telefon-Bold.ttf
- Replace Telefon Bold with sans-serif fallback in share portal
- Remove select2() calls from 5 legacy report/workshop views
- Delete CKEditor vendor directory and models (gem already disabled)
- Delete select2 CSS from public/vendor
- Clean up empty vendor/assets directories

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
CSS is served via Vite, not the Sprockets pipeline.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Keep Telefon-Bold.ttf since it's actively used in the share portal
layout and the global @font-face declaration.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant