Open
Conversation
maebeale
commented
Feb 15, 2026
| ) | ||
| when "title" | ||
| @workshops = @workshops.order(title: :asc) | ||
| @workshops = @workshops.order(Arel.sql(TITLE_SORT_SQL)) |
Collaborator
Author
There was a problem hiding this comment.
order case insensitively and stripped chars
maebeale
commented
Feb 15, 2026
| t.integer "organization_id" | ||
| t.bigint "person_id" | ||
| t.integer "organization_id", null: false | ||
| t.integer "person_id", null: false |
Collaborator
Author
There was a problem hiding this comment.
not sure why person_id wasn't a true fk
maebeale
commented
Feb 15, 2026
| scope = double("scope", respond_to?: false) | ||
| allow(scope).to receive(:respond_to?).with(:total_entries).and_return(false) | ||
| allow(scope).to receive(:respond_to?).with(:count).and_return(true) | ||
| allow(scope).to receive(:unscope).with(:select).and_return(scope) |
Collaborator
Author
There was a problem hiding this comment.
was hitting some ahoy test errors
maebeale
commented
Feb 15, 2026
spec/system/workshops_spec.rb
Outdated
|
|
||
| # Open the dropdown | ||
| click_on "Windows Type" # this clicks the <button> text/label | ||
| click_on "Windows Audience" # this clicks the <button> text/label |
Collaborator
Author
There was a problem hiding this comment.
changed button text to hopefully increase discoverability
maebeale
force-pushed
the
copilot/enhance-ux-for-organization-view
branch
from
e4f5ebf to
8138919
Compare
maebeale
changed the title
Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>
maebeale
force-pushed
the
copilot/enhance-ux-for-organization-view
branch
from
292c93e to
82eb40b
Compare
maebeale
commented
Feb 16, 2026
| authorize! | ||
| @category_types = CategoryType.published.order(:name).decorate | ||
| @sectors = Sector.published | ||
| @category_types = CategoryType.published.where(story_specific: false).order(:name).decorate |
Collaborator
Author
There was a problem hiding this comment.
don't show StoryPopulation on Workshops index
maebeale
commented
Feb 16, 2026
| include PunctuationStrippable | ||
| authorize :user | ||
|
|
||
| TITLE_SORT_SQL = "LOWER(TRIM(#{Workshop.strip_punctuation_sql_spaced('workshops.title')})) ASC".freeze |
Collaborator
Author
There was a problem hiding this comment.
doing it as a frozen constant helped avoid brakeman concern
maebeale
force-pushed
the
copilot/enhance-ux-for-organization-view
branch
from
82eb40b to
a905529
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
Grab bag of changes:
How did you approach the change?
Anything else to add?