Conversation
Collaborator
|
@copilot try again |
Contributor
Author
Fixed in commit 819b6ad. The password change forms now display clear password requirements and show specific error messages instead of just the browser's circle-backslash icon. Changes:
|
Copilot
AI
changed the title
[WIP] Fix issue preventing new password creation
Fix password change validation feedback - display clear error messages instead of browser icon
Feb 15, 2026
maebeale
force-pushed
the
copilot/fix-password-reset-issue
branch
from
ec2bc9f to
8d996c5
Compare
- Add visible password requirement hint (5 characters minimum) on change password form - Add visible password requirement hint on Devise password reset form - Enhance password error display with icon and clearer formatting - Create custom Devise error messages partial with better styling - Add HTML5 minlength validation to prevent browser default error icon Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>
- Add spec for users/change_password view to verify password requirements display - Add spec for devise/passwords/edit view to verify password requirements display - Test error message display and formatting Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>
maebeale
force-pushed
the
copilot/fix-password-reset-issue
branch
from
d815c8e to
c73097c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
Users were reporting that when trying to change their password, they only saw a "circle-backslash symbol" (browser's default HTML5 validation icon 🚫) without any explanation of why their password was rejected. This made it impossible for users to understand what they needed to do to successfully change their password.
This PR fixes the issue by providing clear, visible password requirements and enhanced error messages so users understand exactly what's wrong and how to fix it.
How did you approach the change?
1. Added Clear Password Requirements
minlength="5"attribute for browser-level validation/users/change_password) and Devise password reset form2. Enhanced Error Message Display
app/views/users/_password_errors.html.erb) with:role="alert"for accessibility3. Created Consistent Error Handling
app/views/devise/shared/_error_messages.html.erb)4. Added Comprehensive Tests
users/change_passwordformdevise/passwords/editformAnything else to add?
Screenshot:
The form now clearly shows:
Testing:
The changes are minimal and focused, directly addressing the user's complaint while improving the overall UX for password changes throughout the application.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.