Configuring the environment name in Rails#356
Merged
cjlarose merged 5 commits intorubyconfig:masterfrom Mar 16, 2024
Merged
Conversation
…veride the default config environment which is the Rails.env. This allows us to have multiple different environments, without having to worry about making custom rails environments
Feature/rails environment
cjlarose
approved these changes
Mar 16, 2024
Member
|
Previously, we wanted a test for the Railtie, but that ended up being a big hassle. I think we're gonna figure it out in #353 though, so I'm comfortable merging this in as-is and we can add a test later |
Member
|
Released in version 5.4.0 |
Contributor
Author
|
Thanks @cjlarose ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've finally found some time to raise a new PR for this. I originally raised it as #290.
This small new configuration option allows us to specify the name for the rails environment, rather than being limited to using 'development', 'test' and 'production'.
We have multiple rails 'production' environments, so this is needed to support that.
For example, when this new config is enabled (it defaults to how it works now), we would need to set the new environment variable:
or
And have an associated config for it in ./config:. e.g.
@cjlarose FYI - hopefully we can get this in this time, and we can stop referencing a copy of this gem from our private gem repository 😄