Add support for Cloud Foundry (cf)#161
Open
alanyjw wants to merge 7 commits intorubyconfig:masterfrom
Open
Conversation
|
👍 |
Member
|
I will review it tomorrow. Could you in the meantime squash your commits? |
divyabhargov
force-pushed
the
add-support-for-cf
branch
3 times, most recently
from
884cb77 to
137094e
Compare
|
Done 😄 |
gamov
force-pushed
the
add-support-for-cf
branch
from
711aa34 to
ca0391f
Compare
Signed-off-by: Natalie Tay <ntay@pivotal.io> Signed-off-by: Alan Yeo <ayeo@pivotal.io> Signed-off-by: Benjamin Tan <btan@pivotal.io>
gamov
force-pushed
the
add-support-for-cf
branch
from
ca0391f to
247119b
Compare
rdubya
reviewed
Jul 1, 2019
|
|
||
| out = '' | ||
| dotted_hash = to_dotted_hash Kernel.const_get(Config.const_name).to_hash, {}, Config.const_name | ||
| dotted_hash = to_dotted_hash Kernel.const_get(Config.const_name).to_hash, namespace: Config.const_name |
Contributor
There was a problem hiding this comment.
I think this now needs to be Object.const_get
Member
Member
|
@alanyjw you put a lot of work into this PR, unfortunatelly tests are failing. Do you wanna fix it? |
|
@pkuczynski I'll have a look when I find some time. |
Member
|
Cool thanks! |
Member
|
Issues
======
+ Solved 8
- Added 88
Complexity increasing per file
==============================
- lib/config/integrations/helpers/cf_manifest_merger.rb 3
- lib/config/integrations/helpers/helpers.rb 5
Complexity decreasing per file
==============================
+ lib/config/integrations/heroku.rb -2
See the complete overview on Codacy |
|
@pkuczynski I tried cloning rubyconfig on my computer and follow the steps in CONTRIBUTING.md but when I run For both this pull request and master. I use RVM and a dedicated gemset. Is there anything that jumps to your mind that I'm doing wrong? PS: I also did the same thing in a ruby:2.6 container; I've got the exact same result. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.