Skip to content

Modernize dependencies and fix CI#62

Merged
dduugg merged 9 commits intomainfrom
fix-ruby-34-nokogiri-compat
Mar 5, 2026
Merged

Modernize dependencies and fix CI#62
dduugg merged 9 commits intomainfrom
fix-ruby-34-nokogiri-compat

Conversation

@dduugg
Copy link
Contributor

@dduugg dduugg commented Mar 5, 2026

Summary

CI uses the shared workflow at rubyatscale/shared-config/.github/workflows/ci.yml, which tests against Ruby 3.2, 3.3, and 3.4. Several gems in the lock file were incompatible with Ruby 3.4, causing bundle install to fail.

Dependency updates:

  • Fix Ruby 3.4 CI failure: nokogiri-1.16.4-x86_64-linux has a hard constraint of < 3.4.dev; updated to 1.19.1
  • Update all outdated gems: rails 7.0 → 8.1, rubocop 1.45 → 1.85, sorbet/tapioca 0.5/0.7 → 0.6/0.17, packwerk 2.2 → 3.2, rack 2 → 3, and many more
  • Bump bundler to 4.0.7
  • Remove git-sourced packwerk override from Gemfile — no longer needed now that packwerk 3 is on RubyGems
  • Bump packwerk dependency in gemspec from >= 2.2.1 to >= 3, consistent with the README
  • Bump required_ruby_version in gemspec from >= 2.7 to >= 3.2 to match the lowest Ruby version tested in CI

Sorbet/Tapioca:

  • Regenerate all tapioca RBI files for updated gem versions
  • Regenerate rdoc RBI under Ruby 4.0 to fix type check failure

Linting:

  • Add rubocop-gusto as a development dependency and plugin in .rubocop.yml
  • Autocorrect 62 rubocop offenses (rubocop -a)
  • Generate .rubocop_todo.yml for remaining 73 violations

Fixes https://github.com/rubyatscale/packwerk-extensions/actions/runs/22682101326

@dduugg dduugg requested a review from a team March 5, 2026 18:00
@github-project-automation github-project-automation bot moved this to Triage in Modularity Mar 5, 2026
@dduugg dduugg enabled auto-merge (squash) March 5, 2026 18:01
@dduugg dduugg changed the title Fix Ruby 3.4 CI failure: update nokogiri to 1.19.1 Fix Ruby 3.4 CI failure and modernize dependencies Mar 5, 2026
@dduugg dduugg closed this Mar 5, 2026
auto-merge was automatically disabled March 5, 2026 18:17

Pull request was closed

@github-project-automation github-project-automation bot moved this from Triage to Done in Modularity Mar 5, 2026
@dduugg dduugg reopened this Mar 5, 2026
@dduugg dduugg changed the title Fix Ruby 3.4 CI failure and modernize dependencies Modernize dependencies and fix CI Mar 5, 2026
@dduugg dduugg enabled auto-merge (squash) March 5, 2026 18:30
@dduugg dduugg closed this Mar 5, 2026
auto-merge was automatically disabled March 5, 2026 18:30

Pull request was closed

@dduugg dduugg reopened this Mar 5, 2026
@dduugg dduugg closed this Mar 5, 2026
@dduugg dduugg reopened this Mar 5, 2026
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a fast-follow it could be worth letting claude take a pass through resolving/minimizing as many of these as we can.

Copy link

@dkisselev dkisselev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dduugg dduugg merged commit f869297 into main Mar 5, 2026
19 checks passed
@dduugg dduugg deleted the fix-ruby-34-nokogiri-compat branch March 5, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants