Merged
Conversation
auto-merge was automatically disabled
March 5, 2026 18:17
Pull request was closed
auto-merge was automatically disabled
March 5, 2026 18:30
Pull request was closed
dkisselev
reviewed
Mar 5, 2026
| # Note that changes in the inspected code, or installation of new | ||
| # versions of RuboCop, may require this file to be generated again. | ||
|
|
||
| # Offense count: 3 |
There was a problem hiding this comment.
As a fast-follow it could be worth letting claude take a pass through resolving/minimizing as many of these as we can.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI uses the shared workflow at
rubyatscale/shared-config/.github/workflows/ci.yml, which tests against Ruby 3.2, 3.3, and 3.4. Several gems in the lock file were incompatible with Ruby 3.4, causingbundle installto fail.Dependency updates:
nokogiri-1.16.4-x86_64-linuxhas a hard constraint of< 3.4.dev; updated to 1.19.1packwerkdependency in gemspec from>= 2.2.1to>= 3, consistent with the READMErequired_ruby_versionin gemspec from>= 2.7to>= 3.2to match the lowest Ruby version tested in CISorbet/Tapioca:
rdocRBI under Ruby 4.0 to fix type check failureLinting:
rubocop-gustoas a development dependency and plugin in.rubocop.ymlrubocop -a).rubocop_todo.ymlfor remaining 73 violationsFixes https://github.com/rubyatscale/packwerk-extensions/actions/runs/22682101326