Simplify offense data model by removing adapter pattern #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the adapter classes (PackageAdapter, ConstantAdapter, ReferenceAdapter, LocationAdapter) from PksOffense that existed solely to make it compatible with Packwerk::ReferenceOffense interface. Instead, use PksOffense's direct properties throughout: - offense.constant_name instead of offense.reference.constant.name - offense.file instead of offense.reference.relative_path - offense.line instead of offense.location.line - offense.defining_pack_name instead of offense.reference.constant.package.name Update Check::OffensesFormatter interface to accept PksOffense directly instead of Packwerk::ReferenceOffense, and update DefaultFormatter to resolve constant locations via Private.constant_resolver. Closes dp-5q5
Contributor
Author
|
Merging into #62 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan